Accurately annotate Error system with [[noreturn]] #8564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the ErrorReport type into two types:
WarningReport
, which does not throw/abort on destruction.ErrorReport
, which always throws/aborts on destruction, and is annotated with[[noreturn]]
.This makes
internal_error
a valid statement to use at the end of a function that would otherwise fail to return.Also applies
HALIDE_ALWAYS_INLINE
to theoperator<<
overload because it was getting specialized for every size ofconst char *
literal.