Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for the removed DataLayout constructor. #8391

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Fix for the removed DataLayout constructor. #8391

merged 4 commits into from
Aug 13, 2024

Conversation

mcourteaux
Copy link
Contributor

@mcourteaux mcourteaux commented Aug 13, 2024 •
edited
Loading

This fixes the latest change in LLVM where the DataLayout constructor that accepts a Module is removed. llvm/llvm-project@75c7bca

CC @steven-johnson

@mcourteaux mcourteaux mentioned this pull request Aug 13, 2024
Open
@steven-johnson
Copy link
Contributor

Thanks for the fix, but this needs to be conditionalized for multiple versions of LLVM. I'll upload a patch.

steven-johnson
steven-johnson reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green

@steven-johnson steven-johnson self-requested a review August 13, 2024 16:50
@mcourteaux
Copy link
Contributor Author

mcourteaux commented Aug 13, 2024 •
edited
Loading

No it doesn't, afaik. The getDataLayout() was always there. The build bots confirm that it works.

@alexreinking
Copy link
Member

No it doesn't, afaik. The getDataLayout() was always there. The build bots confirm that it works.

I agree it's better to avoid #if when it's not necessary.

@steven-johnson steven-johnson merged commit 818f42d into halide:main Aug 13, 2024
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

@alexreinking alexreinking alexreinking approved these changes

@halidebuildbots halidebuildbots Awaiting requested review from halidebuildbots

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcourteaux @steven-johnson @alexreinking