Clean up really long line lengths in Anderson2021 #7728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have an explicit line length limit in Halide, but generally consider 120 to be a reasonable extent; a lot of code in Anderson2021 went waaaay over this limit, especially function/method calls. I did a semi-manual cleanup to try to clean up the worst offenders. Should be 100% cosmetic.
abadams
reviewed
Jul 31, 2023
| @@ -86,11 +90,15 @@ struct State { | |||
| uint64_t structural_hash(int depth) const; | |||
|
|
|||
| // Compute the parent and depth of every loop nest node | |||
| void compute_loop_nest_parents(map<const LoopNest *, pair<const LoopNest *, int>> &p, | |||
| const LoopNest *here, int depth) const; | |||
| void compute_loop_nest_parents(map<const LoopNest *, | |||
There was a problem hiding this comment.
Oh, good catch, I misread the comma in manual formatiing, willfix
abadams
reviewed
Jul 31, 2023
|
|
||
| void set_gpu_store_site(const map<const LoopNest *, pair<const LoopNest *, int>> &parent, const LoopNest *loop, LoopNest::Sites &site) const; | ||
| void set_gpu_store_site(const map<const LoopNest *, | ||
| pair<const LoopNest *, int>> &parent, |
There was a problem hiding this comment.
Oh, good catch, I misread the comma in manual formatiing, willfix
|
Fixed the weirdness by adding a type alias for the funky map type, since it's used in several places |
|
Failures unrelated, PTAL |
abadams
approved these changes
Aug 2, 2023
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Clean up really long line lengths in Anderson2021 We don't have an explicit line length limit in Halide, but generally consider 120 to be a reasonable extent; a lot of code in Anderson2021 went waaaay over this limit, especially function/method calls. I did a semi-manual cleanup to try to clean up the worst offenders. Should be 100% cosmetic. * Add LoopNestMap * Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have an explicit line length limit in Halide, but generally consider 120 to be a reasonable extent; a lot of code in Anderson2021 went waaaay over this limit, especially function/method calls. I did a semi-manual cleanup to try to clean up the worst offenders. Should be 100% cosmetic.