Backport xtensa_codegen to main (v2) #7432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [xtensa] Add xtensa_io.cpp This is a better option than posix_io.cpp on Xtensa * Update xtensa_io.cpp
* [xtensa] DMA support improvements. This includes multiple related changes: * all transactions are 2D. * Each buffer will use a separate DMA channel. * For the case when destination is an output buffer, we can delay the wait for completion until the beginning of it's producer. * Fix review comments * Handle an error in halide_init_dma * Address review comments
Fix was made in Codegen_C.cpp a while back; the cache must be clear and end-of-func to avoid trying to share assignments between do-par-for lambdas.
Passing __user_context doesn't always get the constness right; _ucon does and is terser
Extend fp16 support for Xtensa
* handle min/max expressions in strides calculations * more robust check for nested loops
…#7303) * [xtensa] added infrastructure code for running tests * moved google related calls to CL
…8215) Fixed index conversion for gather_load with undefined ramp
* [xtensa] Added a new optimize rule to avoid int32->int64->int32 path for a saturated cast of widening shift right * [xtensa] Added tests for i32_sat(widening_shifts) to simd_op_checik_xtensa * xtensa shifts handle 32th shift for int32x word differently. Adjusted the tests and add a missing rule for the optimizer. * Commented on the constraints for the IVP_SRSN_2X32 instruction argument
…o xtensa-codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the branch for Xtensa codegen into main. Note that it deliberately ignores changes to apps/ (which had grown stale); those changes may or may not be backported at a later date.
Aside from simd_op_check_xtensa, there are few tests for the new codegen paths; the next step to remedy that will be updating the buildbots to add code coverage for the existing test suite to the extent that is possible via AOT only (since the Xtensa codegen does not support JIT).