fix: Reload and update schemas - saves the last changes #1197
Conversation
emanuelaepure10
force-pushed
the
fix/ING-4307
branch
from
4243004
to
b9b7579
Compare
| @@ -884,8 +885,8 @@ public void run() { | |||
|
|
|||
| @Override | |||
| public void update() { | |||
| // no change check as this is done by clean before a new project is | |||
| // loaded | |||
| // check if there are changes, as you are about to load the same project | |||
There was a problem hiding this comment.
Related to the original comment, how is the behavior in this case?
- open a project
- modify it
- new alignment project
There was a problem hiding this comment.
You will get this question
and here depends by the user and his answer if the changes will be saved or not.
There was a problem hiding this comment.
Also a question related to the issue (#956) - the description says the possibility to save the project was offered, but the changes were not saved. Is that also the behavior you observed?
The main task of the changeCheck method seems to be to show that dialog, that was also shown before according to the issue description. So does your change solve this by showing it at an earlier time and the later point where it was already checked does not result in the dialog being shown?
There was a problem hiding this comment.
Also a question related to the issue (#956) - the description says the possibility to save the project was offered, but the changes were not saved. Is that also the behavior you observed?
I do observe the same behaviour.
The main task of the changeCheck method seems to be to show that dialog, that was also shown before according to the issue description. So does your change solve this by showing it at an earlier time and the later point where it was already checked does not result in the dialog being shown?
It is exactly how you say. The solution solves the problem showing the dialog earlier. The dialog is not showed anymore later because the changes has ben saved so when checking if there is any change the clean method exit immediately without showing again the dialog.
emanuelaepure10
force-pushed
the
fix/ING-4307
branch
from
cd7bc6f
to
bf31b84
Compare
emanuelaepure10
added
the
challenged
emanuelaepure10
force-pushed
the
fix/ING-4307
branch
from
bf31b84
to
7d7c513
Compare
By using the "Reload and update schemas" button the saving function it's working saving all the changes done to the project. ING-4307 Closes halestudio#956
emanuelaepure10
force-pushed
the
fix/ING-4307
branch
from
7d7c513
to
91125f2
Compare
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
By using the "Reload and update schemas" button the saving function it's working saving all the changes done to the project.
ING-4307
Closes #956