Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow usage of LookupTableImpl and LookupTableInfoImpl in Groovy #1187

Merged
merged 1 commit into from
May 28, 2024

Conversation

florianesser
Copy link
Member

Allow the usage of the classes LookupTableImpl and LookupTableInfoImpl to make it possible to use LookupService in Groovy scripts without having to lift the restrictions.

ING-4256

Copy link
Member

@stempler stempler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that conclude challenging #1166 ?

Copy link
Contributor

@emanuelaepure10 emanuelaepure10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Florian for adding them. I just didn't know what else should be added.

@florianesser
Copy link
Member Author

Does that conclude challenging #1166 ?

Yes, I would say so. I've asked @Kate-Lyndegaard in the ING ticket to re-challenge it with the build from this PR and the example project I attached to the ING ticket.

Copy link

github-actions bot commented May 27, 2024

hale studio builds for this pull request:

Build triggered for commit e6da4e6.
Artifacts are retained for 14 days.

Allow the usage of the classes `LookupTableImpl` and `LookupTableInfoImpl` to
make it possible to use `LookupService` in Groovy scripts without having to
lift the restrictions.

ING-4256
@florianesser
Copy link
Member Author

Challenged by @Kate-Lyndegaard (Jira comment)

@florianesser florianesser added the challenged For PRs to indicate that the implementation has been challenged label May 28, 2024
@florianesser florianesser merged commit 6b96ff9 into master May 28, 2024
4 of 5 checks passed
@florianesser florianesser deleted the feat/lookupservice-whitelist branch May 28, 2024 15:06
Copy link

we-release bot commented Jun 19, 2024

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@we-release we-release bot added the released label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenged For PRs to indicate that the implementation has been challenged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add an additional binding for the service provider to Groovy scripts
3 participants