build: change files related to the creation of the windows installer #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapil-agnihotri
requested review from
florianesser,
kapil-agnihotri and
stempler
and removed request for
florianesser
florianesser
requested changes
Jul 18, 2023
emanuelaepure10
force-pushed
the
master
branch
3 times, most recently
from
1cc308c
to
c5a4f79
Compare
emanuelaepure10
force-pushed
the
master
branch
3 times, most recently
from
41b72dd
to
7f1ac56
Compare
florianesser
requested changes
Jul 20, 2023
There was a problem hiding this comment.
@emanuelaepure10 Please make sure that there are not merge commits in the commit list before merging/rebasing this into master. The commit history in master should be linear and not contain merge commits.
Also FYI: merging of PRs should always be done via "Rebase and merge" not "Squash and merge".
The following changes have been done to solve the windows installer build error: - add encoding UTF-8 to all the replace into file - add more details in how to create the windows installer - update GUID used for shortcuts. ING-3831
Update CHANGELOG.md ING-3831
|
@florianesser I just create a new PR from a new branch. I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes have been done to solve the windows installer build error:
and changelog.md text has been align with the release 5.0.1 text.
ING-3831