Documentation

hal · May 6, 2024 · 555da38 · 555da38
1 parent 33ad3fd
commit 555da38
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -457,7 +457,6 @@ Elemento offers a very basic router. The router is minimal invasive and built ar
 See the API documentation of [PlaceManager](https://hal.github.io/elemento/apidocs/org/jboss/elemento/router/PlaceManager.html) for more details.
 
 ```java
-@Route("/time/:area/:location")
 public static class TimePage implements Page {
 
     @Override
@@ -481,13 +480,17 @@ public static class Application {
         body().add(div().id("main"));
         new PlaceManager()
                 .root(By.id("main"))
-                .register(place("/home")
+                .register(place("/time/:area/:location")
                         .loader((place, parameter) -> {
                             String area = parameter.get("area");
                             String location = parameter.get("location");
-                            return fetch("https://worldtimeapi.org/api/timezone/" + area + "/" + location)
+                            String url = "https://worldtimeapi.org/api/timezone/" + area + "/" + location;
+                            return fetch(url)
                                     .then(Response::json)
-                                    .then(json -> Promise.resolve(Js.<JsPropertyMap<String>>cast(json).get("datetime")));
+                                    .then(json -> {
+                                        JsPropertyMap<String> map = Js.cast(json);
+                                        return Promise.resolve(map.get("datetime"));
+                                    });
                         }), TimePage::new)
                 .start();
     }

diff --git a/router/src/demo/java/PlaceManagerDemo.java b/router/src/demo/java/PlaceManagerDemo.java
@@ -20,7 +20,6 @@
 import org.jboss.elemento.router.Parameter;
 import org.jboss.elemento.router.Place;
 import org.jboss.elemento.router.PlaceManager;
-import org.jboss.elemento.router.Route;
 
 import elemental2.dom.HTMLElement;
 import elemental2.dom.Response;
@@ -41,7 +40,6 @@
 public class PlaceManagerDemo {
 
     // @start region = placeManager
-    @Route("/time/:area/:location")
     public static class TimePage implements Page {
 
         @Override
@@ -65,13 +63,17 @@ public void entryPoint() {
             body().add(div().id("main"));
             new PlaceManager()
                     .root(By.id("main"))
-                    .register(place("/home")
+                    .register(place("/time/:area/:location")
                             .loader((place, parameter) -> {
                                 String area = parameter.get("area");
                                 String location = parameter.get("location");
-                                return fetch("https://worldtimeapi.org/api/timezone/" + area + "/" + location)
+                                String url = "https://worldtimeapi.org/api/timezone/" + area + "/" + location;
+                                return fetch(url)
                                         .then(Response::json)
-                                        .then(json -> Promise.resolve(Js.<JsPropertyMap<String>>cast(json).get("datetime")));
+                                        .then(json -> {
+                                            JsPropertyMap<String> map = Js.cast(json);
+                                            return Promise.resolve(map.get("datetime"));
+                                        });
                             }), TimePage::new)
                     .start();
         }

diff --git a/router/src/main/java/org/jboss/elemento/router/Parameter.java b/router/src/main/java/org/jboss/elemento/router/Parameter.java
@@ -21,7 +21,7 @@
 import static java.util.Collections.emptyMap;
 
 /**
- * The Parameter class is used to represent parameters in a route path. A parameter is a part of the path that starts with a
+ * The Parameter class is used to represent parameters and their values in a route path. A parameter is a part of the path that starts with a
  * colon (e.g. ":id"). Parameters are used to retrieve values from a path.
  */
 public class Parameter {