Adds mmap support to BC, color, mis and sssp #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Iaf10a340d1d3eda73441b112ef285fd6151c1df5
The commit does a few things related to simple renames of GCN3. GCN3 is replaced with Vega in all locations. The targets gfx801 and gfx803 are replaced with the corresponding gfx9 APU and dGPU targets (gfx902 and gfx900 respectively). The docker commands update v22-1 with v23-1. This newer docker image contains an MPI install so that HACC can be built without a separate docker image. The location of the prebuilt binaries is updated to a v24-0 path. The old paths contain binaries built with gfx801, gfx802, and gfx900. They are therefore missing gfx902 and should be rebuilt before the next release.
This application has not been updated with bump to ROCm 4.0 in GPU SE mode. The code is still written in ROCm 1.6 style and therefore does not compile and there are include files missing. Not sure what the purpose of this resource is, so removing it in future releases.
The contents of the HACC docker file have been integrated into gcn-gpu docker v23-1+ and therefore the additional docker image is no longer necessary. The Dockerfile is deleted and the README is updated to be similar to the READMEs for other GPU applications.
This PR is part of [gem5/#703](gem5/gem5#703) to update documentation. These commits do the following: - Replace GCN3_X86 with VEGA_X86 for build and run commands. - Replace gfx801 and gfx803 with gfx902 and gfx900 respectively. - Update pre-built binary website paths to a v24-0 folder. These will have to be rebuilt to removed gfx8 targets and add gfx902. - Update the docker version in READMEs to v23-1. This docker contains the additional packages and env variables to build HACC. - Remove the hsa-agent-pkt application. This application has been broken for years and only builds with ROCm 1.6, so assuming it is no longer used.
There is a bug in either llvm, clang, or hipcc shipped with ROCm 6.0 that causes fgets to hang in gem5, abort in qemu, and seg fault on real hardware. This seems to be a compiler issue and using fstream instead solves the problem. This commit updates all of the graph parser readers to use fstream instead of fgets/FILE pointers.
These were already removed from stable. The disk image and README are wildly out of date. There is already a disk image folder but the README needs to be rewritten.
These were already removed from stable. The disk image and README are wildly out of date. There is already a disk image folder but the README needs to be rewritten.
Change-Id: I2b82d04d7aa47647c8ec84e80751a74639defb05
Change-Id: Id6d16743fcb1ea611742db7a57a47e879166539b
Change-Id: Idb4fc32d4691795bba623d579153459d79a1f2f6
Change-Id: Iff2b7df77e083a064838cd65e26ea1a92ffcf0d3
mattsinc
requested changes
Apr 15, 2024
There was a problem hiding this comment.
It seems like there are a lot of patches from the public integrated here that make seeing your differences difficult. Maybe that update to mirror public needs to happen first?
Regardless there are a couple minor things:
- READMEs need to be updated to explain mmap'ing support
- It would be much better to have a header file per application when there are multiple variants, to reduce code bloat
- It would be better to map the filenames application specific, as the applications when all run on Condor will be launched from the same/similar folder
- It would be better to have absolute paths to the files for mmap'ing
Of these, the application specific filenames is the only urgent one that needs to be part of this patch. The rest I think can be done in subsequent patches. Nice job!
| @@ -335,52 +335,26 @@ To compile: | |||
| To clone the gem5-resources repository, run the following command: | |||
|
|
|||
| ``` | |||
| git clone https://gem5.googlesource.com/public/gem5-resources | |||
| git clone https://github.com/gem5/gem5-resources | |||
There was a problem hiding this comment.
I am not sure this should be part of the mmap patch, but is also something that is needed
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| title: GCN3 DNNMark Tests | |||
| title: VEGA DNNMark Tests | |||
There was a problem hiding this comment.
Same thing with many of these files. Did you include a patch from Matt P or something?
| @@ -129,7 +350,7 @@ int main(int argc, char **argv) | |||
| int *color_d; | |||
| int *node_value_d; | |||
| int *stop_d; | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.