feat: solvers - consume full swap amount #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the swap amount calculation logic in
swap_lib
to better handle rounding errors when calculating swap amounts.Description
As part of the reintegration of Solvers with AVNU, their team identified that in some exact in swaps, the amount actually consumed is lower than the amount requested even though liquidity is enough to fill the swap.
This happens because we calculate the net swap amount based on available liquidity, and add back fees using the
net_to_fee
util function. This leads to rounding errors in some cases, where the actual amount consumed deviates +/- 1 from the requested swap amount.This PR adds a fix to consume the full swap amount for exact in swaps that that are fully filled over non-zero liquidity.
Testing