This repository has been archived by the owner on Sep 22, 2024. It is now read-only.
Attempt to remove previous state when starting the server #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robem
changed the title
robem
force-pushed
the
robem/remove-previous-state
branch
from
4bf7848
to
3d47bdf
Compare
|
Yes, we cannot really do that, because you will also remove all data associated with sessions. Maybe there is some bugs in the code that reloads session data, but that code is needed for situations like you shutdown KTS while you have a couple of sessions running, or while a session is frozen due to whatever bug in KTS. Restarting a server will allow to pick up the previously active sessions and let them run again without having to restart everything everywhere. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to figure out why highlighting is getting screwed unpredictably #223 , I send out #314 but this introduced error messages on startup when launching kakoune. Hence, this change is more radical. I suspect that previous sockets/buffers/fifos remain which corrupt new sessions. This is a "quickfix" to simply remove all previous state. @hadronized I assume there is a reason why you didn't do this in the first place.
So far, this has been the only fix that is 100% reliable for me.