Skip to content

Commit

Permalink
Refactor functions that heavily rely on None types (#429)
Browse files Browse the repository at this point in the history
* refactor functions with obscure type definitions

* add mypy to dev dependencies

* add type check to `ci.yml`

* linting

* typo

---------

Co-authored-by: Marco Giulini <[email protected]>
  • Loading branch information
rvhonorato and mgiulini authored Aug 6, 2024
1 parent 6894a58 commit 736a351
Show file tree
Hide file tree
Showing 5 changed files with 616 additions and 480 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ jobs:

- run: poetry install --no-interaction --no-root

- name: Check types
run: poetry run mypy src/ --ignore-missing-imports --explicit-package-bases --disallow-incomplete-defs # --check-untyped-defs

- name: Run sanity check on the API endpoints
run: poetry run pytest -m sanity -vvv

Expand Down
Loading

0 comments on commit 736a351

Please sign in to comment.