chore: drop zxch3n/tidy
#1190
Merged
chore: drop zxch3n/tidy
#1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we remove the `@zxch3n/tidy` dependency in favor of our own hard fork `@hackworthltd/tidyt-wasm` and a bit of vendoring for the non-Wasm bits. Specifically: 1. Drop `@zxch3n/tidy`. 2. Add a `@hackworthltd/tidyt-wasm` dependency, which now provides the Wasm bits that `@zxch3n/tidy` previously did. 3. Vendor `tidy.ts` from `@zxch3n/tidy`, as this is the only bit of upstream that we need. (We also use `dispose.ts`, but that itself was vendored in `@zxch3n/tidy`, and we expect it's temporary, anyway; see #1187.) 4. Use a Vite plugin for loading Wasm modules, so we can drop the boilerplate `initWasm` step that `@zxch3n/tidy` requires. Note that we vendor `tidy.ts` from this upstream commit: zxch3n/tidy@54382fa Our vendored `tidy.ts` is nearly identical to upstream at that commit, except that a) we don't need the `initWasm` stuff, as explained above, and b) we pull the `visit` function into the file as well. (The latter lives in `utils.ts` in the upstream project.) Note that there are a few TypeScript errors in our vendored `tidy.ts`. These errors are also present in the upstream version, but they do not manifest in the running code, which appears to work identically to the upstream code it replaces. We will fix these TypeScript errors in a subsequent commit, but not here, as I want the diff vs. upstream to be as clean as possible in this initial vendoring commit. Fixes #1186. Signed-off-by: Drew Hess <[email protected]>
This is just an expedient fix. A proper fix is tracked in: #1189 Signed-off-by: Drew Hess <[email protected]>
Pure styling, no functional changes here. Signed-off-by: Drew Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.