chore: upgrade to React Flow v12 #1173
Conversation
|
This appears to work, with one exception. 
It's not clear yet whether this is an upstream bug, or something that didn't port correctly. Also, the bug described in #1148 is still present, though it's much less frequent: whereas with React Flow v11.10.4 and later it happens on the first node selection with Chrome, with this version of React Flow, it happens only rarely on any browser. I'd hoped this might be an 11.x-only bug, but it appears not. |
dhess
force-pushed
the
dhess/reactflow-12
branch
from
b924210 to
b8cab9a
Compare
|
Similar to React Flow v11.10.4 as noted in #1148 (comment), the bug described in #1148 is very difficult to trigger with React Flow v12 when deployed; in fact, I have not managed to trigger it yet after recreating a program that triggers it 100% (in Chrome) when running the app locally via |
This was fairly easy to do. I followed the guide posted here: xyflow/xyflow#3764 Besides the renamed imports, the only particularly notable changes required were: * Replacing `unknown` type parameters with more specific types, as React Flow now has better types; and * changing `node.parentNode` with `node.parentId`, which fixed an issue where Primer `match` branch labels were misplaced. Signed-off-by: Drew Hess <[email protected]>
dhess
force-pushed
the
dhess/reactflow-12
branch
from
b8cab9a to
6bbf659
Compare
|
The branch label bug is now fixed. All that was required was to change |
No description provided.