Refactor plugin paths and move custom reveal plugin #1898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yukai Huang <[email protected]>
Signed-off-by: Yukai Huang <[email protected]>
…ugins Signed-off-by: Yukai Huang <[email protected]>
Yukaii
force-pushed
the
chore/dev-1884-adjust-revealjs-plugin-build
branch
from
241c612 to
9f0e3a7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the plugin paths for spotlight and elapsed-time-bar in slide.js and relocates the custom reveal plugin to the public/js directory.
- Updated webpack rules to copy the plugins from public/js
- Modified dependency URLs in slide.js to reflect the new plugin paths
- Relocated and added ESLint disabling comments to the spotlight and elapsed-time-bar plugins
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| webpack.common.js | Added a new rule to copy plugins from public/js into revealjs-plugins |
| public/js/slide.js | Updated dependency URLs for spotlight and elapsed-time-bar plugins |
| public/js/revealjs-plugins/spotlight/spotlight.js | Added an ESLint disable comment at the top |
| public/js/revealjs-plugins/elapsed-time-bar/elapsed-time-bar.js | Added an ESLint disable comment at the top |
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
[nitpick] Using a blanket 'eslint-disable' can hide potential issues; consider disabling only the specific ESLint rules that require suppression.
Suggested change
| /* eslint-disable */ | |
| /* eslint-disable no-var, no-unused-vars */ |
Copilot uses AI. Check for mistakes.
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
[nitpick] Consider disabling only targeted ESLint rules instead of using a blanket disable to maintain better code quality.
Suggested change
| /* eslint-disable */ | |
| /* eslint-disable no-var, prefer-arrow-callback, no-unused-vars */ |
Copilot uses AI. Check for mistakes.
stanley2058
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update plugin paths for spotlight and elapsed-time-bar in slide.js and relocate the custom reveal plugin to the public/js directory.