-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix issue with SQlite connection #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: yamashush <[email protected]> Signed-off-by: Ali Bellamine <[email protected]>
Signed-off-by: Yukai Huang <[email protected]> Signed-off-by: Ali Bellamine <[email protected]>
Signed-off-by: Ali Bellamine <[email protected]>
Signed-off-by: Ali Bellamine <[email protected]>
I was wondering why a migration was created to add an index in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issues with the SQLite connection in the docker image by adjusting the migration logic for adding and removing the index on the "Revisions" table.
- Adds a migration to create an index on the "noteId" column
- Provides a down migration to remove the index
Files not reviewed (1)
- deployments/docker-entrypoint.sh: Language not supported
}, | ||
|
||
down: (queryInterface, Sequelize) => { | ||
return queryInterface.removeIndex('Revisions', 'noteId') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The down migration is attempting to remove an index using the name 'noteId', but the up migration does not explicitly name the index. Consider providing an explicit index name in queryInterface.addIndex so that removeIndex can reference the correct name.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Hi @alibell, |
The current docker image doesn't work with SQLite.
There are two main issues :
The current fix resolve these two issues.