Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes team member from project profile #7932

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

jsnhn
Copy link
Member

@jsnhn jsnhn commented Feb 21, 2025

Fixes #7843

What changes did you make?

  • Removed Roslyn Wythe's information from _projects/website.md

Why did you make the changes (we will use this info to test)?

  • To keep list of active HfLA members on the website up-to-date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Screenshot 2025-02-20 at 3 47 35 PM

Visuals after changes are applied

Screenshot 2025-02-20 at 3 48 32 PM

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jsnhn-remove-website-info-7843 gh-pages
git pull https://github.com/jsnhn/website.git remove-website-info-7843

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 21, 2025
@DDVVPP DDVVPP self-requested a review February 21, 2025 21:12
@DDVVPP
Copy link
Member

DDVVPP commented Feb 21, 2025

Review ETA: 4 PM PT 02/21/25
Availability: 11 AM - 5 PM PT Tue-Fri

Copy link
Member

@DDVVPP DDVVPP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsnhn Great job on your good first issue!

  • The pull request is made with the correct branch
  • The issue is correctly linked
  • Roslyn Wythe has been removed from projects/website per issue requirements

Minor suggestion: I noticed that there are no CodeQL alerts in your PR (yay!), so it would be nice to check off that box in your PR comment next time! Same comment applies to the checkboxes in your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Status: PR Needs review
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Website Remove Roslyn Wythe
2 participants