Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved bug for FAQ page for className attribute - 1511 #1548

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Resolved bug for FAQ page for className attribute - 1511 #1548

merged 1 commit into from
Dec 3, 2023

Conversation

agutiernc
Copy link
Member

Fixes #1511

What changes did you make?

  • Replaced boolean expression with ternary

Why did you make the changes (we will use this info to test)?

  • To remove warning about receiving false for a non-boolean attribute className

Screenshots of Proposed Changes Of The Website

No visual changes

entrotech
entrotech approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@entrotech entrotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will merge and deploy to dev environment.

@entrotech entrotech merged commit 6b8f6d0 into develop Dec 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@entrotech entrotech entrotech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Warning: Received false for a non-boolean attribute className on FAQ page
2 participants
@agutiernc @entrotech