1544 myprojects filter #1547
Merged
1544 myprojects filter #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1544
What changes did you make?
Implemented filtering on the My Projects Page
This deviates from the design proposed by the UI/UX Team:
I used an animated drawer for the filter, similar to yelp or Amazon, that can be collapsed, instead of the proposed tooltip design. The convention seems to be for filter panels to appear on the left, so that's what I did, though it's a little awkward to have the Filter By button on the right, then open the drawer on the left. The UI/UX team should review this and make suggestions to improve this design, or decide to go back to the idea of a tooltip pop-up panel for specifying the filters.
I set it up so any changes are applied immediately, and there is no need for the "Apply" button.
The Search Box above the grid did accept a string, and look for that string in most fields, including name, business permit no, alternate #, and even dates. I added criteria to the filter panel to specifically search by name, address, alternate # and author (only if the user is an admin), and modified the Search Box above the grid to only search through the name, address, author and alternate # fields. We should decide if we want to get rid of the Search Box entirely.
I chose not to implement DRO and Date Submitted as filter criteria for now, since those features are not yet implemented, and wouldn't work.
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied