Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors Account API Endpoints Tests #1535

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Refactors Account API Endpoints Tests #1535

merged 2 commits into from
Nov 25, 2023

Conversation

agosmou
Copy link
Member

@agosmou agosmou commented Nov 25, 2023 •
edited
Loading

Follows code style and conventions discussed in #1521

What changes did you make?

  • Split up tests into different 'describe blocks' and added 'before' block into them.
  • The tests remain the same, but improved, so they are isolated.

Why did you make the changes (we will use this info to test)?

  • Addresses tech debt: makes the previously written tests more robust and clearer to understand/maintain

@agosmou agosmou merged commit accea7d into develop Nov 25, 2023
2 checks passed
@agosmou agosmou deleted the ag-account-tests-refactor branch February 16, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@agosmou