Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Warning: Received false for a non-boolean attribute className on FAQ page #1511

Closed
ZekeAranyLucas opened this issue Nov 13, 2023 · 2 comments · Fixed by #1548
Closed

BUG: Warning: Received false for a non-boolean attribute className on FAQ page #1511

ZekeAranyLucas opened this issue Nov 13, 2023 · 2 comments · Fixed by #1548
Labels
bug Release Note: Shows as Error Correction dev: technical debt Reimplement a former quick fix in a more robust way to ease future development and maintenance. good first issue Good for newcomers level: easy priority: MUST HAVE role: front-end Front End Developer
Milestone
09 - Implementati...

Comments

@ZekeAranyLucas
Copy link
Member

Overview

FaqView.jsx#378 initializes the border style improperly

<div className={admin && classes.editCategoryContainer}>

Action Items

[] make sure the proper class name is used for both admin true and false
[] replace boolean expression with ternary
@ZekeAranyLucas ZekeAranyLucas added bug Release Note: Shows as Error Correction good first issue Good for newcomers role: front-end Front End Developer level: easy dev: technical debt Reimplement a former quick fix in a more robust way to ease future development and maintenance. labels Nov 13, 2023
@Biuwa Biuwa added this to the 09 - Implementation Planning milestone Nov 16, 2023
@HuijungYoon
Copy link

can i have with this issue?

@ZekeAranyLucas
Copy link
Member Author

Take it. To test your changes make sure to run as both admin and non-admin user.

@agutiernc agutiernc self-assigned this Nov 30, 2023
@agutiernc agutiernc mentioned this issue Dec 2, 2023
Merged
@ExperimentsInHonesty ExperimentsInHonesty moved this to On Dev - not yet pushed to Prod in P: TDM: project board Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Release Note: Shows as Error Correction dev: technical debt Reimplement a former quick fix in a more robust way to ease future development and maintenance. good first issue Good for newcomers level: easy priority: MUST HAVE role: front-end Front End Developer
Projects
P: TDM: project board
Status: Released
Milestone
09 - Implementation Planning
Development

Successfully merging a pull request may close this issue.

Resolved bug for FAQ page for className attribute - 1511 hackforla/tdm-calculator
4 participants
@agutiernc @HuijungYoon @ZekeAranyLucas @Biuwa