-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create table project status 46 #449
base: main
Are you sure you want to change the base?
Create table project status 46 #449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Denzel,
Thank you for working on this! I tested it, and everything worked well on my end. I just have a couple of questions:
- Why are the descriptions on the 5th and 6th lines in quotation marks in the app/core/initial_data/PD_Table and Field Explanations - ProjectStatus - Data.csv file? Do you think this has an impact on how the code works?
- Shouldn't the uuid field be mentioned in the _seed.py file?
Hey Del, thanks for the comments.
|
I guess it depends on if we still need it set to specific values. The values it's being set to in the spreadsheet aren't really UUID values. Originally, I let the database generate the ID/UUID values since it's an auto-generated field and the initial data sheets didn't have the values. Then @ethanstrominger said he needed to set the values for testing purposes, so we did that for some of the tables. But I don't think it's being used in tests right now? We should bring this up at the meeting and ask if we still need to set this. |
Fixes #46
What changes did you make?
Why did you make the changes (we will use this info to test)?
N/A