Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Storage page #29

Merged
merged 28 commits into from
Aug 26, 2024
Merged

feat: Storage page #29

merged 28 commits into from
Aug 26, 2024

Conversation

ZeroWave022
Copy link
Member

@ZeroWave022 ZeroWave022 commented Aug 22, 2024

Add a storage page. The front-end should be ready to go.

Functionality still must be added, including:

  • Filters
  • Categories
  • Search

Closes #17

@ZeroWave022 ZeroWave022 marked this pull request as ready for review August 23, 2024 10:30
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@michaelbrusegard
Copy link
Member

I wrote a long reply but managed to refresh the page... Anyways

Firstly, the code is well written, good job on that. You changed some things in the package.json you should not have, but that is okay. The page is missing a loading.tsx and the page for the individual items, but if you want to do that in separate issues, that is fine.

Some UI issues I found:

  • The search bar, filters, and categories are not responsive, and does not work on mobile.
  • The title of the page needs some padding. You can copy the padding from the news page.
  • The sort results box should be a dropdown that shows the currently selected item and it should not be green since it is not a CTA (call to action) button.

Some missing features:
I forgot to tell you, but it was requested on the old website to implement a shopping cart for the storage page that never got finished. This is something we need. It should save to local storage in the browser.
We need selection UI, and hover UI to improve the UX.

I think we should use something as inspiration for the design (just inspiration). For instance komplett.
Screenshot 2024-08-24 at 19 52 33
We dont need the description text, and the price can be where the text for amounts of items is. Just moving some stuff around. By looking at other webpages it is easy to see if something is missing or forgotten.

Anyways, I am very proud of your work so far!

@ZeroWave022
Copy link
Member Author

ZeroWave022 commented Aug 25, 2024

Hey @michaelbrusegard, all of the changes you requested are now added to the storage page, including:

  • A loading.tsx displaying a skeleton when the page is loading
  • A button for the shopping cart
    • This will be expanded upon, but should be an own issue imo
  • The search bar, filters and categories have been adjusted to your specifications
    • They're responsive on smaller devices
    • The sort results button is updated with a neutral color
  • Padding to page title added
  • Some changes to how each card looks - this is something we discussed in-person

Any additional changes (such as the shopping cart and the implementation of the filters/categories) should be added in separate PRs so other team members can use the various components added as a result of this PR. It's also generally easier to review smaller pull requests instead of having everything done at once.

If you still notice some issues that I have missed, please let me know and I'll get them fixed before merging!

@ZeroWave022 ZeroWave022 changed the title Storage page feat: Storage page Aug 25, 2024
@michaelbrusegard
Copy link
Member

LGTM, merge when you want

@ZeroWave022 ZeroWave022 merged commit 9974673 into main Aug 26, 2024
1 check passed
@ZeroWave022 ZeroWave022 deleted the storage-page branch August 26, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Storage page
2 participants