Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the effect of DECGRA on Background Select #18

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

j4james
Copy link
Contributor

@j4james j4james commented Oct 17, 2021

This test demonstrates how the DECGRA dimensions determine the extent of the area that is filled by the Background Select functionality. It also shows how both the Background Select parameter and the DECGRA extent have an influence on which pixels are rendered as transparent.

This is basically an attempt to cover all the weird edge cases we discussed in issue #5. If I've interpreted everything correctly, I'd expect the output to look like this:

image

This test demonstrates how the DECGRA dimensions determine the extent
of the area that is filled by the Background Select functionality. It
also shows how both the Background Select parameter and the DECGRA
extent have an influence on which pixels are rendered as transparent.
@j4james
Copy link
Contributor Author

j4james commented Oct 17, 2021

Btw, if the output on the VT340 doesn't look like the screenshot above, please let me know before merging if possible. That way I can try and fix it before you do the screen capture, so you're not wasting your time on something that's going to have to be replaced.

@hackerb9
Copy link
Owner

Btw, if the output on the VT340 doesn't look like the screenshot above, please let me know before merging if possible. That way I can try and fix it before you do the screen capture, so you're not wasting your time on something that's going to have to be replaced.

It's actually easier for me to merge it before doing the screen capture, if that's alright with you.

@hackerb9
Copy link
Owner

Almost...
image

@j4james
Copy link
Contributor Author

j4james commented Oct 19, 2021

It's actually easier for me to merge it before doing the screen capture, if that's alright with you.

Not a problem. And this looks like an easy fix. I've just misunderstood how default values are interpreted in DECGRA. I thought they default to the max value (which is what would happen if there is just one DECGRA), but when you've got more than one, a default value in the second one will inherit the value from the first one (assuming that wasn't also default).

When the dimensions in a DECGRA command are not specified, it uses the
values from any preceding DECGRA (if there is one), and only falls back
to using the maximum extent as a last resort.
@hackerb9 hackerb9 merged commit dc6cb4f into hackerb9:main Oct 20, 2021
@hackerb9
Copy link
Owner

Works. Interesting that DECGRA keeps previous value.

https://raw.githubusercontent.com/hackerb9/vt340test/main/j4james/background_select.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants