Fixed white blocks after shuffling + allowed reduced motion #1038
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BudzioT
requested review from
malted,
maxwofford and
polytroper
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Gitstar-OC
reviewed
Dec 24, 2024
| @@ -166,7 +166,10 @@ export default function Matchups({ session }: { session: HsSession }) { | |||
| if (currentStep >= totalSteps) { | |||
| clearInterval(spinInterval) | |||
| document.body.style.transform = 'rotate(0deg)' // reset to initial state | |||
| document.body.style.paddingTop = '1px' | |||
| document.body.style.paddingTop = '0' | |||
There was a problem hiding this comment.
Just a question deleting this line may work why we are setting it to 0 ?
There was a problem hiding this comment.
Actually we don't need to set it to 0, I was just testing stuff and left it - transform and willChange is enough
There was a problem hiding this comment.
But it doesn't change anything, as it's initially 0 too, so Ig it's up to reviewer to leave it or not ; )
There was a problem hiding this comment.
Setting it to 1px fixed the white blocks issue before which was why it was included FYI
|
Tested - LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some weird white blocks were showing up after shuffling at the top and bottom, fixed that.
Also made animation's duration 0 when prefers-reduced-motion is set