Merge pull request #1009 from hackclub/taciturnaxolotl/slack-link

hackclub · Dec 21, 2024 · 779101c · 779101c
2 parents b7298e2 + ac12006
commit 779101c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/app/harbor/battles/project-card.tsx b/src/app/harbor/battles/project-card.tsx
@@ -227,7 +227,8 @@ export default function ProjectCard({
         )}
         <a
           target="_blank"
-          href={`https://slack.com/app_redirect?channel=${project.entrant__slack_id}`}
+          href={`https://hackclub.slack.com/team/${project.entrant__slack_id}`}
+          rel="noreferrer"
         >
           <Pill glyph="slack" color="purple" msg="Chat on Slack" />
         </a>

diff --git a/src/app/harbor/signpost/best-ships.tsx b/src/app/harbor/signpost/best-ships.tsx
@@ -36,15 +36,23 @@ export default function BestShips() {
                   }
                 />
                 <div className="flex gap-3">
-                  <a target="_blank" href={partialShip.repoUrl}>
+                  <a
+                    target="_blank"
+                    href={partialShip.repoUrl}
+                    rel="noreferrer"
+                  >
                     <Pill
                       classes="bg-white/15 text-white"
                       glyph="github"
                       msg="Repository"
                       color="gray"
                     />
                   </a>
-                  <a target="_blank" href={partialShip.deployUrl}>
+                  <a
+                    target="_blank"
+                    href={partialShip.deployUrl}
+                    rel="noreferrer"
+                  >
                     <Pill
                       classes="bg-white/15 text-white"
                       glyph="view-forward"
@@ -56,7 +64,8 @@ export default function BestShips() {
                 {partialShip.entrantSlackId ? (
                   <a
                     target="_blank"
-                    href={`https://slack.com/app_redirect?channel=${partialShip.entrantSlackId}`}
+                    href={`https://hackclub.slack.com/team/${partialShip.entrantSlackId}`}
+                    rel="noreferrer"
                   >
                     <Pill
                       glyph="slack"