Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Consolas font for the cards #92

Merged
merged 5 commits into from
Dec 30, 2024
Merged

Conversation

emergenitro
Copy link
Contributor

Summary of the problem

It's to fix the font and make it more similar to the actual HCB cards. The HCB cards fall back to Consolas which I've added.

Describe your changes

I just added a font file and then used useFonts to use the font

Checklist

  • Descriptive PR title (Does the title explain the changes in a concise manner?)
  • Tag related issues so they auto-close on merge
  • Easily digestible commits (Are the commits small and easy to understand?) video
  • CI passes (Do the GitHub checks pass?)
  • Tested by submitter before requesting review (Does it work in development iOS/android? )

image

P.S. I will look into the merge conflicts after submitting the PR

Copy link
Collaborator

@thedev132 thedev132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only replaced the bold font, could you replace all instances? Also don't remove .env file

Copy link
Collaborator

@thedev132 thedev132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@thedev132 thedev132 merged commit 51b4203 into hackclub:main Dec 30, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants