Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pan.hackclub.com #1259

Closed
wants to merge 4 commits into from
Closed

Conversation

mridun-gupta
Copy link

Adding pan.hackclub.com

Description

Required subdomain for a new locale of HackClub's website.

+ DNS for subdomain 'pan'/'pan.hackclub.com'
@mridun-gupta mridun-gupta requested review from a team as code owners August 22, 2024 21:55
Copy link
Member

@alx-alexpark alx-alexpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please put the domain in the correct place in the file based on alphabetical order!

Otherwise, everything looks good! Will hold for hackclub/global#115

@Muirrum
Copy link
Member

Muirrum commented Aug 23, 2024

Which language is this for? don't believe pan is a ISO631-1 code.

@mridun-gupta
Copy link
Author

It is for Punjabi actually.

@mridun-gupta
Copy link
Author

@alx-alexpark I already sorted domain pan to it's location in p.

@alx-alexpark
Copy link
Member

Hi!

I'm waiting for your pull request to be approved on the hackclub/global repository.

As Cara said, I'm not too sure myself if pan is a ISO631-1 code, so I will wait for them to decide.

@mridun-gupta
Copy link
Author

I got it.

- from 'pan' locale to 'pa' locale
@mridun-gupta
Copy link
Author

Sorry, @alx-alexpark and @Muirrum, Cara was right, I made a minor issue (now, fixed), I misread the ISO631-3 code instead of the ISO631-1 code for the Punjabi/Panjabi language.

@Muirrum
Copy link
Member

Muirrum commented Aug 24, 2024

closing as duplicate of #1219

@Muirrum Muirrum closed this Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants