Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starts implementation for --force system & establishes naming consistency #1161

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jaspermayone
Copy link
Contributor

This PR starts the implementation for a --force system as well as establishing some constancy for workflow/file naming.

See https://hackclub.slack.com/archives/C05SVRTCDGV/p1714867674790609?thread_ts=1714613706.014109&cid=C05SVRTCDGV for why the validation flow is currently blocked, but this PR will at least establish a manual workflow unblocking the other PR's, until we establish an auto labeler / system.

@jaspermayone jaspermayone self-assigned this May 5, 2024
@jaspermayone jaspermayone requested review from a team as code owners May 5, 2024 00:11
@jaspermayone
Copy link
Contributor Author

Oh hrm this doesn't look good.
CleanShot 2024-05-04 at 20 12 25@2x

@jaspermayone jaspermayone requested a review from Muirrum May 5, 2024 00:29
Copy link
Member

@alx-alexpark alx-alexpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i guess

@jaspermayone
Copy link
Contributor Author

Okay it seems to be having problems with paths

Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine w/ this landing but would note that the sync and sync-force workflows could, instead of being carbon copies of each other, be shared and extended via decoration using the github reusable workflow pattern. This would result in reduced LOC and ensure these workflows are kept in sync over time as changes are needed in one or the other.

@jaspermayone
Copy link
Contributor Author

Oh interesting I wasn't aware of that. Will implement!

@grymmy
Copy link
Contributor

grymmy commented May 6, 2024

@jaspermayone just ping me when u want re-review

Copy link
Member

@Muirrum Muirrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the actions is much appreciated :) lgtm!

@jaspermayone
Copy link
Contributor Author

Docs on --force here octodns/octodns#1170

@jaspermayone jaspermayone enabled auto-merge (squash) June 1, 2024 22:38
@jaspermayone jaspermayone removed their assignment Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants