Switch to wildcard for zone config #1159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muirrum
requested changes
May 10, 2024
Comment on lines
-60
to
-64
| lenient: true | ||
| sources: | ||
| - config | ||
| targets: | ||
| - dnsimple |
There was a problem hiding this comment.
It looks like there's some custom config here -- how should we handle this?
There was a problem hiding this comment.
@Muirrum can you elaborate here?
|
On 5/10/24 10:14, Jasper Mayone wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In config/production.yaml
<#1159 (comment)>:
> - lenient: true
- sources:
- - config
- targets:
- - dnsimple
@Muirrum <https://github.com/Muirrum> can you elaborate here?
Sure, basically it looks like hackclub.app has custom config that's not
currently being applied in the diff.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches our octodns file to use a wildcard based config system, so we don't have to add new domains into our yaml file.
See octodns docs here ~ https://github.com/octodns/octodns/tree/main?tab=readme-ov-file#dynamic-zone-config
If this isn't wanted/needed feel free to close the PR, just noticed this in the docs and thought it might be useful!