Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎢 Add basic joyride tour for navbar #479

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

Feeshay
Copy link
Member

@Feeshay Feeshay commented Jul 20, 2021

Status:

🚧 In development

Description

  • Add joyride tour for home page nav bar

Problems:

  • The tour displays for the nav bar no matter where you are on the site. Since the nav bar is at a higher level (App.js) than the home page idk if there's a way to reference the entire home page (especially since we're referencing components inside the navbar) unless we do some really convoluted component passing
  • The tour keeps re-appearing on refresh. idk if that's good or not lol

Resolves #475

Todos

  • Styling
  • Translations

Screenshots

image
image
image
image

@vercel
Copy link

vercel bot commented Jul 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hack4impact/nawc/2KQKZmVQFXeuJnQVEBFRxNqHuBEv
✅ Preview: https://nawc-git-joyride-start-hack4impact1.vercel.app

@github-actions
Copy link

Flow Coverage

File Difference
client/src/components/Navigation.jsx +3.2%

@cypress
Copy link

cypress bot commented Jul 20, 2021



Test summary

24 0 0 0Flakiness 0


Run details

Project ymca
Status Passed
Commit efc922c
Started Jul 20, 2021 9:03 PM
Ended Jul 20, 2021 9:05 PM
Duration 02:13 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React joyride on the homepage
1 participant