Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Fix bug for subcategory naming #350

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

nkonjeti
Copy link
Contributor

@nkonjeti nkonjeti commented Mar 1, 2021

Status:

Can't update existing resources because those have "subcategory"

Description

Changed "subcategory" name to "subcategories" in Resource model. Adjusted backend endpoints to this change. Tested deleting and renaming subcategories with Postman by creating a new resource.

Fixes #

Todos

Screenshots

Editing subcategory name to "updated"
Screen Shot 2021-03-01 at 1 02 09 PM
Screen Shot 2021-03-01 at 1 02 51 PM
Deleting subcategory name with "updated" in category "health"
Screen Shot 2021-03-01 at 1 08 32 PM
Screen Shot 2021-03-01 at 1 16 17 PM

@vercel
Copy link

vercel bot commented Mar 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hack4impact/nawc/AG1oS5nTNQkEExXH5xJRzSSKftHE
✅ Preview: https://nawc-git-change-subcategory-naming-hack4impact1.vercel.app

@github-actions github-actions bot changed the title Fix bug for subcategory naming 🐞 Fix bug for subcategory naming Mar 1, 2021
@cypress
Copy link

cypress bot commented Mar 1, 2021



Test summary

19 0 0 0


Run details

Project ymca
Status Passed
Commit 774ee58
Started Mar 1, 2021 7:20 PM
Ended Mar 1, 2021 7:22 PM
Duration 01:47 💡
OS Linux Ubuntu - 18.04
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@nkonjeti nkonjeti marked this pull request as ready for review March 1, 2021 19:25
@nkonjeti nkonjeti marked this pull request as draft March 1, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant