Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite PWA For The Website #55

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Vite PWA For The Website #55

merged 7 commits into from
Feb 14, 2024

Conversation

Shinjan-saha
Copy link
Contributor

#44 Issue Solved

As Suggested used the Workbox Method for Caching Assets

@Shinjan-saha
Copy link
Contributor Author

@tamalCodes Can you please review the PR

@tamalCodes
Copy link
Member

@tamalCodes Can you please review the PR

Sure, I was not well TBH. Also need some documentation - can you say what are the different strategies that are being used here for caching ?

@Shinjan-saha
Copy link
Contributor Author

@tamalCodes Can you please review the PR

Sure, I was not well TBH. Also need some documentation - can you say what are the different strategies that are being used here for caching ?

I used Vite-plugin & workbox approach for the caching of assets such as images

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM, let me do a couple of tests locally, I also have suggested a couple of changes

vite.config.js Outdated Show resolved Hide resolved
vite.config.js Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 4d60515
✅ Preview: https://s3-website-mhqq0p37d-h4b-2.vercel.app
🔍 Inspect: https://vercel.com/h4b-2/s3-website/5d31T7LQDfXJiXYsFLCUk8jSXqxQ

View Workflow Logs

@tamalCodes tamalCodes merged commit fe14674 into hack4bengal:main Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants