-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX]: Improved Accessibility to 100% #53
Conversation
@tamalCodes Thanks for your guidance i finally made it to 100% in both mobile and the desktop . Its nice to have a guidance from person like you. Can i get any of your social media connection like linkedin to take guidance if i needed. Here is the link check it out https://s3-website-cprngnlkx-h4b-2.vercel.app/ . Thank you . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, amazing contribution howver:
There's a missing image error in the Footer of the current site which is fixed in the main site
Also I realised that the colour of the background heading has been altered a little bit to match the contrasts in the accessibility is it possible that we reduce the opacity or make it much more similar to what we have currently ?
@tamalCodes I changed the color very minimal so that the accessibility stays 100% .So changing color is little bit difficult the accessibility will be lowered. I will change the bg image and I will submit my PR.Thank you. I am ready take the seo to 100% too if you assign me by any chance . |
This pull request has been deployed to Vercel.
|
@tamalCodes Everything is fixed you can merge it now. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work !
@tamalCodes Can you assign me the performance or seo improvement ? Thank you. |
closes #48