Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Improved Accessibility to 100% #53

Merged
merged 24 commits into from
Jan 12, 2024

Conversation

harith-hacky03
Copy link

@harith-hacky03 harith-hacky03 commented Jan 10, 2024

closes #48

@harith-hacky03 harith-hacky03 changed the title alt tags added [ FIX ] : Issue #48 Improved Accessibility to 100% Jan 10, 2024
@harith-hacky03
Copy link
Author

@tamalCodes Thanks for your guidance i finally made it to 100% in both mobile and the desktop . Its nice to have a guidance from person like you. Can i get any of your social media connection like linkedin to take guidance if i needed. Here is the link check it out https://s3-website-cprngnlkx-h4b-2.vercel.app/ . Thank you .

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, amazing contribution howver:

There's a missing image error in the Footer of the current site which is fixed in the main site

image

Also I realised that the colour of the background heading has been altered a little bit to match the contrasts in the accessibility is it possible that we reduce the opacity or make it much more similar to what we have currently ?

image

@tamalCodes tamalCodes changed the title [ FIX ] : Issue #48 Improved Accessibility to 100% [FIX]: Improved Accessibility to 100% Jan 11, 2024
@tamalCodes tamalCodes added 🐞 bug Fixes for something that isn't working. status: need changes 🚧 Changes have been requested for these PRs labels Jan 11, 2024
@harith-hacky03
Copy link
Author

@tamalCodes I changed the color very minimal so that the accessibility stays 100% .So changing color is little bit difficult the accessibility will be lowered. I will change the bg image and I will submit my PR.Thank you. I am ready take the seo to 100% too if you assign me by any chance .

Copy link

This pull request has been deployed to Vercel.

Latest commit: 2fbd252
✅ Preview: https://s3-website-l91ypxft8-h4b-2.vercel.app
🔍 Inspect: https://vercel.com/h4b-2/s3-website/HAoxb6nUNvqroQFrHN5ybWRBH3GM

View Workflow Logs

@harith-hacky03
Copy link
Author

@tamalCodes Everything is fixed you can merge it now. Thank you.

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work !

@tamalCodes tamalCodes merged commit f54652d into hack4bengal:main Jan 12, 2024
1 check passed
@harith-hacky03
Copy link
Author

@tamalCodes Can you assign me the performance or seo improvement ? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Fixes for something that isn't working. status: need changes 🚧 Changes have been requested for these PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Improving acessibility of the website
2 participants