[libffi] Update libffi to 3.3 #3348
Conversation
Signed-off-by: Graham Weldon <[email protected]>
There was a problem hiding this comment.
These code changes look good to me. Note that this has 118 rdeps, including a number that will probably time-out currently in bldr (like core/llvm and core/python2). We'll probably want to coordinate merging this with @MindNumbing or @gavindidrichsen
|
@MindNumbing @gavindidrichsen - Any comments? |
|
Please refrain from merging until we come up with a solution to this problem internally. May need a work around or a temporary extension to the build timeout in the meantime. |
|
Added DO NOT MERGE tag, and assigning to @MindNumbing |
|
@MindNumbing Any update on this? |
|
@predominant Haven't picked this up for a while, will discuss it this week with the builder team. |
|
Thanks :) |
|
The timeouts have been increased, I will run some checks to make sure that the build will still work with the latest libifi |
|
Nope, timeout is still canceling this job. |
|
Now that #3450 has been approved and #3472 has been merged, these plans are no longer available in this repository. Please see Additional Plans for more information. Closing this PR, feel free to re-open at the new location. Sadly this won't fix the issue with bldr not being able to build the rdeps without going over the timeout limit |
Signed-off-by: Graham Weldon [email protected]