Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust][rust-nightly] Add missing rust/rust-nightly dependencies #3031

Closed

Conversation

MindNumbing
Copy link
Contributor

Signed-off-by: Steven Marshall [email protected]

closes #2226

@MindNumbing MindNumbing requested review from fnichol, reset and a team as code owners September 12, 2019 15:15
@chef-expeditor
Copy link
Contributor

Hello MindNumbing! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MindNumbing. Great work here! Would be worth having a go at adding a simple test for the correct version as per instructions here. Have a go and then compare with my attempt in this draft PR.

Also, I'm going to stick a 'do-not-merge' label on this just in case it needs special treatment like core/rust, which is a base-plan.

@smacfarlane: Can you comment on this?

@stale
Copy link

stale bot commented Jul 8, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used by stalebot to mark a pr as stale label Jul 8, 2020
@stale stale bot removed the stale Used by stalebot to mark a pr as stale label Jul 10, 2020
@MindNumbing
Copy link
Contributor Author

Now that #3450 has been approved and #3472 has been merged, these plans are no longer available in this repository.

Please see Additional Plans for more information.

Closing this PR, feel free to re-open at the new location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rust] [rust-nightly] Missing runtime dependencies
3 participants