add HAB_FUNC_TEST end to end overrides for builder-worker #1735
+31
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwrock
requested changes
Jun 9, 2022
|
|
||
| return res; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think you can avoid all of this repetitive code by creating a token variable and populating it with either bobo or the bldr_token depending on HAB_FUNC_TEST
| section.end()?; | ||
| return Ok(()); | ||
| } | ||
|
|
There was a problem hiding this comment.
rather than repeating these 2 lines, you can wrap the match block below in a if env::var_os("HAB_FUNC_TEST").is_none().
Signed-off-by: pozsgaic <[email protected]>
pozsgaic
force-pushed
the
cjp_worker_func_test
branch
from
453b184
to
e7ccb2c
Compare
mwrock
requested changes
Jun 10, 2022
| .map_err(Error::MpscAsync)?; | ||
| return Err(err); | ||
| if env::var_os("HAB_FUNC_TEST").is_some() { | ||
| // Skip post process |
There was a problem hiding this comment.
You want to use is_none() to avoid the else and empty if
Signed-off-by: pozsgaic <[email protected]>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pozsgaic [email protected]