Settings UI and internals #46
Conversation
ghost
assigned 
*Added a test combo box for future interactions. *Added UnitTests for Settings functions.
TODO: Move it to UnitTests folder.
|
Been a bit busy these days, should do more stuff soon. ;D |
Refactored UnitTests for Settings. UnitTests now get their stub settings xml file. SettingsView stub.
|
@haacked this is how SeeGit settings thing looks atm. Do you have anything to say about it? |
|
I know a change of font could be nice, but dunno what to do if buttons and combos and editboxes look fugly. |
|
Looks a little cramped. Perhaps each setting should be on its own "line". "Commit Description Visibility" should probably be "Show Commit Description". Also, did you know you can just drag an image into the issue comment to display it inline? |
|
Well as long as they are hidden until you click settings, I don't care so On Wed, Apr 24, 2013 at 9:52 AM, Ungureanu Marius
|
|
That's the whole point of the button. :D But yeah, they're hidden until then. |
|
I'll modify those. It was on each on its own line. I'll make it a grid then. And I didn't know the image thing. |
The method is as follows: **Add property to SettingsDataContext. **Create a visual handler for the property in SettingsView.xaml. **Modify App.config xml. **Add updating of ViewModel property in ToggleSettings handler. **Modify your affected ViewModel to handle the property. **Use the property in its specific view. Currently updates happen on toggling off the settings window.
|
The PR can now be merged. Appearance and Layout can be done later, and modifications on the system too. Your choice on merging Phil. |
|
Sorry for the late merge. I forgot about this. You are correct, we can improve the appearance later. :) |
|
It looks a bit better with the Font change though. Still feels a bit cramped, but I haven't found a way to add the options window without taking up too much space. Also, if you have any suggestions on how to improve this system, please tell. ;D |
|
I can implement any suggestions you have. ;D |
Will fix #45.
Modifying settings through a button which makes a dropdown menu. Saving of settings will the done in a .config xml.
Option1: Setting Adorner visibility to Always Visible/Always Hidden/Based on Expanded
Option2: Setting Description in Expander to Visible/Hidden.
Option3: Setting SHA title to short/long SHA
Other will come on the way.
Progress: