Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HELM] Refactor Chart #1872

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

[HELM] Refactor Chart #1872

wants to merge 36 commits into from

Conversation

lakinduakash
Copy link
Member

Reference : #1871

@lakinduakash lakinduakash marked this pull request as ready for review October 25, 2024 08:06
@EshamAaqib
Copy link
Member

@achraf-mer Just wondering if we could remove the Stack mode, is this in use ? Ideally on K8s vLLM should run separately instead of the same pod as h2oGPT I think. WDYT ?

@achraf-mer
Copy link
Collaborator

@achraf-mer Just wondering if we could remove the Stack mode, is this in use ? Ideally on K8s vLLM should run separately instead of the same pod as h2oGPT I think. WDYT ?

yes, we can do separate and keep the help straightforward, let's do, I think we might have used the same pod for latency considerations, but since vLLM can be resource intensive, it is best IMO to have on a separate pod. (more isolation and we can scale separately)

@EshamAaqib
Copy link
Member

@lakinduakash Lets remove Stack mode from h2oGPT and the checks as well, similar to what was done with Agents

@lakinduakash
Copy link
Member Author

@lakinduakash Lets remove Stack mode from h2oGPT and the checks as well, similar to what was done with Agents

Stack is removed

Copy link
Member

@EshamAaqib EshamAaqib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets document the breaking changes that was done to the chart, ex: changing the path of the model lock in values. We will need to communicate this to the other teams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants