Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux full installation tweak #1489

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

juerware
Copy link

Some tweaks for the file docs/linux_install_full.sh

@pseudotensor
Copy link
Collaborator

Hi, can you saw what issues you encountered and what this improves? Thanks!

@juerware
Copy link
Author

juerware commented Mar 26, 2024

Hi, of course I explain the improvements.

  1. while [ $CONDA_SHLVL -gt 0 ]; do conda deactivate; done There can be a recursion in conda and this command reverts any conda session, example in conda sessions base -> h2ogpt -> base (again) -> h2ogpt (again) -> ... -> another session name -> ... -> till infinite
  2. if conda env list | grep -w 'h2ogpt'; then "w" for word is more accurate because "h2ogptBLABLABLA" can be a conda session as well and "h2ogpt" may not be a conda session therefore, there is no need to delete a session which does not exists.
  3. if ! command -v nvcc &> /dev/null; then NVIDIA CUDA Compiler Driver NVCC is required but not informed about it till it fails when installation is running, in this line it is controlled.
  4. if [ ! "$nvccVersion" == "12.1" ] && [ ! "$nvccVersion" == "11.8" ]; then h2ogpt documentation is based on these 2 versions of conda therefore, if these versions are not present in the system it advises about it and the user has the option whether to continue.
  5. if [ "${nvccVersion}" == "11.8" ]; then variables in the system needs to take different values, standard variables are taken from cuda version 12.1

If you need more information, let me know and I explain myself as better as I can.

Thanks in advance.

@juerware
Copy link
Author

do you need anything else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants