GH-16312 move contrained GLM fix from master to release branch (#16317) [nochecks][nocheck] #16383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Continue to double check algo. * fix bug in gradient update. * implemented various version of IRLSM * Found GLM original with gradient magnitude change best * GH-16312: fix wrong error raised by duplicated/conflicted constraints. * force beta constraint to be satisfied at the end if it is not. * GH-16312: add assert check to test per Veronika suggestion. * GH-16312: fix tests after fixing constrained GLM bugs. * GH-16312: fixed NPE error in checkCoeffsBounds * GH-16312: fix test failure. * remove conflicting constraint tests as we currently do not have the capability to do so right now. * change dataset path from AWS to local
maurever
approved these changes
Sep 4, 2024
wendycwong
changed the title
wendycwong
changed the title
wendycwong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue: #16382
No code is generated. Just add changes from master to release branch.