-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-15580] Add information on UniformRobust method for histogram_type
and create an accompanying blog post [nocheck]
#15617
Conversation
histogram_type
and create an accompanying blog posthistogram_type
and create an accompanying blog post [nocheck]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey I left some comments.
- added images - initial issues fix - audience fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hannah-tillman, thanks for your work. I reformat some sentences to be more precious and explainable. Otherwise, it looks good to me. Please check the grammar is ok before implementing the suggested changes. :) Please don't hesitate to let me know if you have any other questions.
h2o-docs/src/product/data-science/algo-params/histogram_type.rst
Outdated
Show resolved
Hide resolved
histogram_type
and create an accompanying blog post [nocheck]histogram_type
and create an accompanying blog post
- uniform failing note - updated histogram_type descrip - slower/less accurate note
@maurever: Please let me know what you both think needs to be changed/re-worked. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hannah-tillman, thanks! Looks good to me. :)
histogram_type
and create an accompanying blog post histogram_type
and create an accompanying blog post [nocheck]
pr predates pull request check migration -- keeps looking for jira ticket
…m_type` and create an accompanying blog post [nocheck] (h2oai#15617) * ht/added blog post w/ example & updated algo-param * ht/add to algo params * ht/requested updates - added images - initial issues fix - audience fix * ht/requested updates - uniform failing note - updated histogram_type descrip - slower/less accurate note * ht/initial draft rewrite for general audience * ht/requested update * ht/rerun checks pr predates pull request check migration -- keeps looking for jira ticket
For: #15580
This PR adds the UniformRobust method to the
histogram_type
algo-param page. It also drafts the initial blog post to be added to the User Guide blog section (I will add to the blog to the h2o.ai/blog/ website after the next release so the information in the Guide is up-to-date).The example I made for the blog might not be the best. I tried to find a dataset with decent outliers since I didn't have the Springleaf dataset mentioned in the original PR. Please let me know if it's okay or how I should update it.