Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-15580] Add information on UniformRobust method for histogram_type and create an accompanying blog post [nocheck] #15617

Merged
merged 7 commits into from
Jul 24, 2023

Conversation

hannah-tillman
Copy link
Contributor

@hannah-tillman hannah-tillman commented Jun 30, 2023

For: #15580

This PR adds the UniformRobust method to the histogram_type algo-param page. It also drafts the initial blog post to be added to the User Guide blog section (I will add to the blog to the h2o.ai/blog/ website after the next release so the information in the Guide is up-to-date).

The example I made for the blog might not be the best. I tried to find a dataset with decent outliers since I didn't have the Springleaf dataset mentioned in the original PR. Please let me know if it's okay or how I should update it.

@hannah-tillman hannah-tillman changed the title [GH-15580] Add information on UniformRobust method for histogram_type and create an accompanying blog post [GH-15580] Add information on UniformRobust method for histogram_type and create an accompanying blog post [nocheck] Jun 30, 2023
Copy link
Contributor

@meganjkurka meganjkurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I left some comments.

h2o-docs/src/product/blog-releases.rst Outdated Show resolved Hide resolved
h2o-docs/src/product/blog-releases.rst Outdated Show resolved Hide resolved
h2o-docs/src/product/blog-releases.rst Outdated Show resolved Hide resolved
- added images
- initial issues fix
- audience fix
Copy link
Contributor

@maurever maurever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannah-tillman, thanks for your work. I reformat some sentences to be more precious and explainable. Otherwise, it looks good to me. Please check the grammar is ok before implementing the suggested changes. :) Please don't hesitate to let me know if you have any other questions.

h2o-docs/src/product/blog-releases.rst Outdated Show resolved Hide resolved
h2o-docs/src/product/blog-releases.rst Outdated Show resolved Hide resolved
h2o-docs/src/product/blog-releases.rst Outdated Show resolved Hide resolved
@hannah-tillman hannah-tillman changed the title [GH-15580] Add information on UniformRobust method for histogram_type and create an accompanying blog post [nocheck] [GH-15580] Add information on UniformRobust method for histogram_type and create an accompanying blog post Jul 17, 2023
- uniform failing note
- updated histogram_type descrip
- slower/less accurate note
@hannah-tillman
Copy link
Contributor Author

@maurever:
@meganjkurka pointed out that the initial draft was too technical for a general audience, so with her help I've started this re-write. When you have time, could you please go back through and check that the information is still correct.

Please let me know what you both think needs to be changed/re-worked. Thank you!

Copy link
Contributor

@maurever maurever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannah-tillman, thanks! Looks good to me. :)

@hannah-tillman hannah-tillman changed the title [GH-15580] Add information on UniformRobust method for histogram_type and create an accompanying blog post [GH-15580] Add information on UniformRobust method for histogram_type and create an accompanying blog post [nocheck] Jul 24, 2023
pr predates pull request check migration -- keeps looking for jira ticket
@mn-mikke mn-mikke merged commit 378eb38 into rel-3.42.0 Jul 24, 2023
@mn-mikke mn-mikke deleted the ht/15580 branch July 24, 2023 20:48
Mohit1345 pushed a commit to Mohit1345/h2o-3 that referenced this pull request Jul 28, 2023
…m_type` and create an accompanying blog post [nocheck] (h2oai#15617)

* ht/added blog post w/ example & updated algo-param

* ht/add to algo params

* ht/requested updates

- added images
- initial issues fix
- audience fix

* ht/requested updates

- uniform failing note
- updated histogram_type descrip
- slower/less accurate note

* ht/initial draft rewrite for general audience

* ht/requested update

* ht/rerun checks

pr predates pull request check migration -- keeps looking for jira ticket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants