New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-15556 Implement UpliftDRF MOJO #15615

Merged

maurever merged 26 commits into master from maurever_GH-15556_upliftdrf_mojo

Sep 26, 2023

Contributor

maurever commented Jun 28, 2023 •

edited

Loading

Closes #15556.

maurever added this to the 3.44.0.1 milestone

maurever self-assigned this

maurever marked this pull request as draft

July 24, 2023 14:44

maurever force-pushed the maurever_GH-15556_upliftdrf_mojo branch from 0ced502 to bab109e Compare

August 23, 2023 09:24

maurever requested review from wendycwong and valenad1

August 23, 2023 13:47

maurever added the Uplift Trees label

maurever commented

View reviewed changes

h2o-core/src/main/java/hex/ModelMetricsBinomialUplift.java Outdated Show resolved Hide resolved

maurever commented

View reviewed changes

h2o-core/src/main/java/water/api/ModelMetricsHandler.java Outdated Show resolved Hide resolved

maurever commented

View reviewed changes

h2o-py/h2o/h2o.py Outdated Show resolved Hide resolved

maurever commented

View reviewed changes

h2o-py/h2o/model/model_base.py Outdated Show resolved Hide resolved

maurever commented

View reviewed changes

h2o-r/h2o-package/R/models.R Outdated Show resolved Hide resolved

maurever marked this pull request as ready for review

August 31, 2023 09:42

maurever requested a review from syzonyuliia

August 31, 2023 09:43

maurever force-pushed the maurever_GH-15556_upliftdrf_mojo branch from 8fdd896 to 1d72a7e Compare

September 1, 2023 11:39

maurever marked this pull request as draft

September 3, 2023 09:36

maurever force-pushed the maurever_GH-15556_upliftdrf_mojo branch from 1d72a7e to e158ee0 Compare

September 13, 2023 12:43

maurever added 13 commits

September 20, 2023 14:04


          Implement ATE, ATT, ATC metrics

1bb9df9


          Fix score with treatment column

9d9a277


          Enable custom metric for UpliftDRF

54c37f7


          fix custom att calculation, add example to doc

af2106b


          GH-6783 fix custom function definition

d1cf383


          Add atc custom, test new metric in R

42adee3


          fix test

c7f6334


          fix att and atc metric bug

28ddaac


          fix make metrics runit

fcb832c


          Fix make_metrics bug

82d5d1e


          GH-15556 implement uplift mojo

9a2f84d


          Prepare mojo/pojo writer and reader

f745536


          Implement mojo structure, add junit test, add easy predict function

21d6235

maurever added 9 commits

September 20, 2023 14:16


          rebase master

2742fbd


          Fix make metrics functionality

8a0ff50


          Fix UpliftOtput annotation

81b6b81


          Fix build

60d5f88


          fix custom auuc threshold api

a17fe60


          fix makeMetrics bug

6173b3f


          Fix make_metrics test

68dcad9


          fix make metrics bug

0e5f59f


          fix mojo bug, fix make_metrics bug, clean code

48afd94

maurever force-pushed the maurever_GH-15556_upliftdrf_mojo branch from 94efba3 to 48afd94 Compare

September 20, 2023 12:17


          Move custom threshold logic from make metrics to another PR

9b74707

maurever commented

View reviewed changes

h2o-py/h2o/model/model_base.py

@@ @@ -460,16 +460,15 @@ def training_model_metrics(self): @@
                       return self._model_json["output"]["training_metrics"]._metric_json
                   def model_performance(self, test_data=None, train=False, valid=False, xval=False, auc_type=None,
-                                        auuc_type=None, auuc_nbins=-1):

Contributor Author

maurever Sep 20, 2023

This parameter is not able to be used. Default model thresholds are used to calculate AUUC. Change in this function is not allowed.

maurever marked this pull request as ready for review

September 20, 2023 13:24


          Move custom threshold logic from make metrics to another PR

b490cfa

maurever force-pushed the maurever_GH-15556_upliftdrf_mojo branch from 0169d57 to b490cfa Compare

September 20, 2023 17:58

maurever added the please review label


          Fix failed tests

821cb4e

maurever force-pushed the maurever_GH-15556_upliftdrf_mojo branch from 206cc50 to 821cb4e Compare

September 21, 2023 08:49

wendycwong approved these changes

View reviewed changes


          Merge branch 'master' into maurever_GH-15556_upliftdrf_mojo

e21625d

maurever merged commit 8856059 into master

2 checks passed

maurever deleted the maurever_GH-15556_upliftdrf_mojo branch

September 26, 2023 08:53

maurever removed the please review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels