Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-15584: Fix python explain re-rendering [nocheck] #15586

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

tomasfryda
Copy link
Contributor

#15584

This bug was introduced with wrapping the plot results in order to be able to return more than just a plot (also data). This caused explanations not to be rendered properly as the figure moved to the .figure().

To reproduce it you can use something like:

df = h2o.import_file("https://h2o-public-test-data.s3.amazonaws.com/smalldata/wine/winequality-redwhite-no-BOM.csv")

response = "quality"

predictors = [
  "fixed acidity", "volatile acidity", "citric acid", "residual sugar", "chlorides", "free sulfur dioxide",
  "total sulfur dioxide", "density", "pH", "sulphates", "alcohol",  "type"
]

aml = H2OAutoML(max_runtime_secs=20, seed=11)
ex = h2o.explain(aml, test)

and then in another jupyter cell

ex

The result before this fix:
Screen Shot 2023-06-16 at 11 44 05

@tomasfryda tomasfryda merged commit 65eceb8 into master Jun 26, 2023
2 checks passed
@tomasfryda tomasfryda deleted the tomf_GH-15584_fix_python_explain_re-rendering branch June 26, 2023 13:04
maurever pushed a commit that referenced this pull request Jul 24, 2023
* Fix python explain re-rendering

* Do not render images when render=False
maurever pushed a commit that referenced this pull request Sep 6, 2023
* Fix python explain re-rendering

* Do not render images when render=False
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants