Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-6779: Add custom metric to leaderboard [nocheck] #15568

Merged
merged 13 commits into from
Jul 13, 2023

Conversation

tomasfryda
Copy link
Contributor

@tomasfryda tomasfryda self-assigned this Jun 9, 2023
@tomasfryda tomasfryda force-pushed the tomf_GH-6779_add_custom_metric_to_leaderboard branch from 0d31788 to ef786d4 Compare June 12, 2023 07:34
@tomasfryda tomasfryda removed the AutoML label Jun 12, 2023
@tomasfryda tomasfryda changed the title GH-6779: Add custom metric to leaderboard GH-6779: Add custom metric to leaderboard [nocheck] Jun 12, 2023
@tomasfryda tomasfryda requested a review from maurever June 19, 2023 14:28
@tomasfryda
Copy link
Contributor Author

@maurever please note that this PR includes the CV fix as it was branched out of this PR so I can use the custom metrics in the leaderboard in the tests.

* Fix custom metric calculation in CV (prototype)

* Allow custom_metric_func in automl

* Return NaN for models that don't support custom metric

* Revert change used to ensure existing metric
* Fix custom metric calculation in CV (prototype)

* Allow custom_metric_func in automl

* Return NaN for models that don't support custom metric

* Revert change used to ensure existing metric

* Add custom metric to SE

* Mention SE support of the custom metric func in docs

* Use directly model metrics in leaderboard

This change is motivated by an issue with SE level-one validation frame
that is ephemeral and can not be checksummed.
@tomasfryda tomasfryda merged commit 43a724d into master Jul 13, 2023
@tomasfryda tomasfryda deleted the tomf_GH-6779_add_custom_metric_to_leaderboard branch July 13, 2023 11:33
maurever pushed a commit that referenced this pull request Sep 6, 2023
* Add custom metric to leaderboard

* Verify sorting by custom metric

* Make sure the custom metrics share the same names

* Fix custom metric calculation in CV (#15576)

* GH-15565: Add custom metric to automl [nocheck] (#15577)

* Fix custom metric calculation in CV (prototype)

* Allow custom_metric_func in automl

* Return NaN for models that don't support custom metric

* Revert change used to ensure existing metric

* GH-15559: Add custom metric to SE [nocheck] (#15579)

* Fix custom metric calculation in CV (prototype)

* Allow custom_metric_func in automl

* Return NaN for models that don't support custom metric

* Revert change used to ensure existing metric

* Add custom metric to SE

* Mention SE support of the custom metric func in docs

* Use directly model metrics in leaderboard

This change is motivated by an issue with SE level-one validation frame
that is ephemeral and can not be checksummed.
maurever pushed a commit that referenced this pull request Sep 6, 2023
* Add custom metric to leaderboard

* Verify sorting by custom metric

* Make sure the custom metrics share the same names

* Fix custom metric calculation in CV (#15576)

* GH-15565: Add custom metric to automl [nocheck] (#15577)

* Fix custom metric calculation in CV (prototype)

* Allow custom_metric_func in automl

* Return NaN for models that don't support custom metric

* Revert change used to ensure existing metric

* GH-15559: Add custom metric to SE [nocheck] (#15579)

* Fix custom metric calculation in CV (prototype)

* Allow custom_metric_func in automl

* Return NaN for models that don't support custom metric

* Revert change used to ensure existing metric

* Add custom metric to SE

* Mention SE support of the custom metric func in docs

* Use directly model metrics in leaderboard

This change is motivated by an issue with SE level-one validation frame
that is ephemeral and can not be checksummed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants