Update wlth-bid-ask-ma-spread.rain #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix on inverted math was sub/add in wrong direction
| stablerevertcondition stablerevert-amount | ||
| if(tokenrevertcondition tokenrevert-amount | ||
| if(stablecondition stable-amount | ||
| if(tokencondition token-amount max-value()) | ||
| ) | ||
| ) | ||
| ), | ||
|
|
||
| price:if( |
There was a problem hiding this comment.
Try replacing the price with the following segment:
mul1: mul(current-price 0.995),
mul2: mul(current-price 1.005),
price: conditions(
stablerevertcondition mul1
tokenrevertcondition mul2
stablecondition mul2
tokencondition mul1
"default" max-value()
);
- The above should solve the problem of too many elements on stack, but probably will get that error if more elements were to be present on the stack. Perhaps try introducing more sources that do some of the calcs.
- Also I'm not sure of the
pricecalculation above is correct becausecurrent-priceis only in one direction and hencemul1andmul2are also in the same direction
There was a problem hiding this comment.
I have added and pushed. That gets past the truncation error.
I have put the "string" in at the end of the conditions. if I put Max Value and the direction is stable outgoing that could still go through? however if token outgoing it wont?
is there an issue there?
There was a problem hiding this comment.
No, if you put max-value as the default value if all conditions are false, it won't go through in either case.
There was a problem hiding this comment.
why is that? it still provides a price?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix on inverted math
was sub/add in wrong direction
Motivation
Solution
Checks
By submitting this for review, I'm confirming I've done the following: