Profit aware grid - Ruby Curve #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedavidmeister
requested changes
Aug 1, 2024
strategies/ruby/buy-curve.rain
Outdated
| #uniswap-words !The address for orderbook subparser. | ||
| #scale-factor !Scale factor for buy curve. | ||
|
|
||
| #in-token-key 0x10b2c7dd2f0c383e8445066430f62720e189027b16a56ad4212eefac8e6c77ed |
There was a problem hiding this comment.
what's going on with all these hardcoded chunks of bytes?
strategies/ruby/buy-curve.rain
Outdated
| #calculate-io | ||
| using-words-from orderbook-subparser uniswap-words | ||
|
|
||
| out-tkn-amount: get(0x469017709316f7f258096e4e2ac47b89e1a104ffa810dcd5c906f95726cdbf78), |
There was a problem hiding this comment.
why isn't this using the key binding that looks like it's supposed to be for this?
strategies/ruby/sell-curve.rain
Outdated
| #ensure-sale-start !Binding to ensure sale has began. | ||
| #test-now !Binding to simulate current time. | ||
|
|
||
| #in-token-key 0x10b2c7dd2f0c383e8445066430f62720e189027b16a56ad4212eefac8e6c77ed |
|
this is no longer relevant for any active customers, if we need it we can dust it off for a specific use case when we have specific requirements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ruby strategy buy and sell curve.
Checks
By submitting this for review, I'm confirming I've done the following: