Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WLTH - community strategies, grid-trading.rain #15

Merged
merged 8 commits into from
Jul 8, 2024
Merged

WLTH - community strategies, grid-trading.rain #15

merged 8 commits into from
Jul 8, 2024

Conversation

dcatki
Copy link
Contributor

@dcatki dcatki commented Jul 5, 2024 •
edited by Siddharth2207
Loading

Grid trading
Tranche
But no recharge
No shyness

Motivation

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs

@dcatki
Create grid-trading.rain
cc2dd53 
Grid trading
Tranche
But no recharge
No shyness
@dcatki dcatki requested a review from Siddharth2207 July 5, 2024 17:40
Siddharth2207
Siddharth2207 reviewed Jul 6, 2024
View reviewed changes
Copy link
Contributor

@Siddharth2207 Siddharth2207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linear, non-recharging tranches with no shyness.

dcatki
dcatki commented Jul 6, 2024
View reviewed changes
Copy link
Contributor Author

@dcatki dcatki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be WLTH/Base.

Strategy header needs to explan the grid strategy simply at the start

Looking good

@dcatki dcatki changed the title Create grid-trading.rain WLTH - community strategies, grid-trading.rain Jul 7, 2024
@Siddharth2207 Siddharth2207 merged commit 52af4a9 into main Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siddharth2207 Siddharth2207 Siddharth2207 left review comments

Assignees

@Siddharth2207 Siddharth2207

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcatki @Siddharth2207