-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A 'textbook' unification algorithm #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was inspired by this code and the associated paper. But the specification of when the algorithm is supposed to fail is weird there:
With such a definition, one is not able to prove the completeness lemma I wanted.
However, with my definition (
unify_failure
), it works:Lemma unify_failure_is_severe {Σ : StaticModel} (es : list eqn) : unify_failure es -> ~ exists s : SubT, is_unifier_of s es .
I wonder why the paper didn't contain any result like that - the specification
UnifyFailure
is not very helpful in saying why the algorithm should fail. Why would anyone take it as a specification?That said, it was definitely easier to take the paper and this inductive as a starting point than starting from scratch.