Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #763] Introduced labelled checkboxes #765

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

michalfita
Copy link

@michalfita michalfita commented Oct 25, 2023

Purpose

To address #763 and improve overall UX of using Checkbox in the application.

Scope

  • The implementation
  • Examples

To do

  • Add label for showing selection over whole Checkbox
  • Create grouping for MultiChoice to make application logic easier
  • Example combining Checkbox and RadioButton

Notes

Commits bring changes incrementally, so I suggest reviewing them one by one and consider rejections based on changes in them as maybe not all PR would need to be rejected at once.

For now I do draft for first impression where I'm heading. I'm trying to not break original API, however, some alignment with RadioButton in future would do good.

@gyscos
Copy link
Owner

gyscos commented May 31, 2024

Thanks for the work!

I merged main into this branch (solving minor conflicts that arose when views became Send), and it should now be closer to ready.

One remark: the example now shows 2 ways to make groups of checkboxes: the "manual way" (for toppings) and the "managed way" (for extras). To keep the example simple, I think we can get rid of the manual way and only show how to use the multichoice group.

Instead, we could include a couple of "non-grouped" checkboxes, to show that it's still an option for single options. Or not, since that's already covered in the "list_view" example. In that case, I would rename the checkbox example to checkbox_group or multichoice_group.

@michalfita
Copy link
Author

@gyscos Oh man, it's been a while since I've been on this... Finding time to go back to this may be close to impossible in a next few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants